Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Change quotes to fix test-command.yml #22146

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[FIX] Change quotes to fix test-command.yml #22146

merged 1 commit into from
Jan 31, 2023

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Jan 31, 2023

What

The if statement in the qa-engine check is failing as github actions prefers single quotes

https://github.com/airbytehq/airbyte/actions/runs/4055079918
actions/runner#866

How

This changes to single quotes

@bnchrch bnchrch enabled auto-merge (squash) January 31, 2023 15:02
@bnchrch
Copy link
Contributor Author

bnchrch commented Jan 31, 2023

/test connector=connectors/source-pokeapi

@bnchrch bnchrch temporarily deployed to more-secrets January 31, 2023 15:03 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets January 31, 2023 15:03 — with GitHub Actions Inactive
@bnchrch bnchrch requested a review from a team January 31, 2023 15:03
erohmensing
erohmensing approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been there before 😅

@bnchrch bnchrch disabled auto-merge January 31, 2023 15:05
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.51% ❌

@bnchrch bnchrch merged commit 7d3b0fe into master Jan 31, 2023
@bnchrch bnchrch deleted the bechurch/disable-qa-engine-check-2 branch January 31, 2023 15:37
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 2, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
This was referenced Feb 8, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnchrch @erohmensing